MDEV-35955 Wrong result for UPDATE ... ORDER BY LIMIT using tmp.table #3804
+238
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queries of the form UPDATE t1.*, t2.* ORDER BY t1.col1, t2.col2, ... LIMIT N; now correctly sort first by t1.col, then by t2.col2. Previously, such queries would, when more than one ORDER BY column was specified, incorrectly sort the columns from the input tables; as an example, when two ORDER BY columns were specified, the sorting would first be by t2.col2 and then by t1.col1, updating more rows from the first table than the second.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries of the form
now correctly sort first by t1.col, then by t2.col2. Previously, such queries would, when more than one ORDER BY column was specified, incorrectly sort the columns from the input tables; as an example, when two ORDER BY columns were specified, the sorting would first be by t2.col2 and then by t1.col1, updating more rows from the first table than the second.